[Bug 2310324] Review Request: VK_hdr_layer - Vulkan Wayland HDR WSI Layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2310324



--- Comment #6 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> ---
Issues:
=======
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages

[!]: Package complies to the Packaging Guidelines
VK_hdr_layer.x86_64: E: invalid-soname /usr/lib64/libVkLayer_hdr_wsi.so
libVkLayer_hdr_wsi.so

For Vulkan layers, they need to be installed outside of the default linker
path.

Install into %{_libdir}/%{name}/layer/ per policy
https://pagure.io/packaging-committee/blob/master/f/guidelines/modules/ROOT/pages/Unversioned_shared_objects.adoc
(the docs aren't generating correctly so I'm referencing the source adoc.)

Ensure that the %{_datadir}/vulkan/implicit_layer.d/VkLayer_hdr_wsi.x86_64.json
is correct for the new path. Keep multi-arch in mind and ensure the absolute
path takes into account %{_libdir}.

An example of where this is done:
https://src.fedoraproject.org/rpms/monado-vulkan-layers


[!]: %check is present and all tests pass.

Just documenting there are no tests.


VK_hdr_layer.x86_64: E: description-line-too-long Vulkan layer utilizing a
small color management / HDR protocol for experimentation.
VK_hdr_layer.x86_64: E: description-line-too-long Implements the following
vulkan extensions, if the protocol is supported by the compositor.

Reformat.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2310324

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202310324%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux