https://bugzilla.redhat.com/show_bug.cgi?id=2264719 Michal Ambroz <rebus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(msuchy@xxxxxxxxxx | |) | |needinfo?(msuchy@xxxxxxxxxx | |) | |needinfo?(msuchy@xxxxxxxxxx | |) --- Comment #13 from Michal Ambroz <rebus@xxxxxxxxx> --- Miroslave sorry I am struggling to reproduce the re-creation of the Source0 tarball. https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#:~:text=MUST:%20The%20sources "MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this." The upstream release is 400kb, Git snapshot is cca 20MB, git-archive-all is cca 25MB, what is in your src.rpm is 125MB. That seems to be huge difference. Following the guide from the spec file I am not able to verify it is the same source. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ If it is not possible to include the full download URL in the Source0, then it is preffered to have a prepared download script, which takes version as argument. Example in https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code As bare minimum there should be repeatable instructions how to obtain the source code. https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2264719 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264719%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
