https://bugzilla.redhat.com/show_bug.cgi?id=2305930 --- Comment #10 from Michael Berry <trismegustis@xxxxxxxxx> --- (In reply to Cristian Le from comment #7) > A few other comments: > - Preferably upload a spec file and srpm that did not expand `rpmautospec` > - The `Summary:` after the `%py_provides` has no effect (py_provides inserts > `Provides:` for the current package definition `btrfs-backup-ng` in this > case, where `Summary:` is already defined. It does not create new packages > [1]) > Similarly `%description -n %{name} %_description` is redundant there. > - Please use `%{pypi_source btrfs_backup_ng}`, the approach with `pypi_name` > is deprecated > - `%pyproject_save_files btrfs_backup_ng` is sufficient > - About: "Check if the automatically generated License and its spelling is > correct for Fedora" > Yes it is correct. Search for the spdx (short) license identifier [2] when > you need to. > - (optional) Some people prefer using macros everywhere, like `%{name}`, > others find it distracting as there is no guaranteed correlation between the > values where it is expanded in. There is no clear templates or automation > tools for python, unlike rust and go, so you can go with either approach > until then. > > I cannot sponsor packagers, so I will leave the official review to whoever > can sponsor you. > > [1]: > https://src.fedoraproject.org/rpms/python-rpm-macros/blob/rawhide/f/macros. > python-srpm#_195 > [2]: https://spdx.org/licenses/ Thabk out Christian -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305930 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305930%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
