https://bugzilla.redhat.com/show_bug.cgi?id=2255751 --- Comment #23 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- Issues: ======= - Header files in -devel subpackage, if present. Note: perfetto-sdk : /usr/share/perfetto/sdk/perfetto.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/perfetto Need to add this %dir, likely to the main %files [!]: Development files must be in a -devel package [!]: Package is named according to the Package Naming Guidelines. [!]: Package complies to the Packaging Guidelines These are all the same for me. Why not just use -devel vs -sdk? [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in perfetto-libs , perfetto-sdk This seems to be fine for the purpose of being able to install the libs or libs+sdk without the main package files. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. No explanation of the one patch and why there is not an upstream bug/PR. [!]: %check is present and all tests pass. Missing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2255751 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255751%23c23 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
