Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Color-Library - Easy-to-use and comprehensive named-color library https://bugzilla.redhat.com/show_bug.cgi?id=430619 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-01-28 23:58 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3d9e519a836aa0a438076ab04c61e31f Color-Library-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave t/00-load.............# Testing Color::Library 0.02, Perl 5.008008, /usr/bin/perl ok t/01-Color-Library....ok t/boilerplate.........ok t/pod-coverage........ok t/pod.................ok All tests successful. Files=5, Tests=250, 5 wallclock secs ( 5.33 cusr + 0.10 csys = 5.43 CPU) + Package perl-Color-Library-0.02-1.fc9 -> Provides: perl(Color::Library) = 0.02 perl(Color::Library::Color) perl(Color::Library::Dictionary) perl(Color::Library::Dictionary::HTML) perl(Color::Library::Dictionary::IE) perl(Color::Library::Dictionary::Mozilla) perl(Color::Library::Dictionary::NBS_ISCC) perl(Color::Library::Dictionary::NBS_ISCC::A) perl(Color::Library::Dictionary::NBS_ISCC::B) perl(Color::Library::Dictionary::NBS_ISCC::F) perl(Color::Library::Dictionary::NBS_ISCC::H) perl(Color::Library::Dictionary::NBS_ISCC::M) perl(Color::Library::Dictionary::NBS_ISCC::P) perl(Color::Library::Dictionary::NBS_ISCC::R) perl(Color::Library::Dictionary::NBS_ISCC::RC) perl(Color::Library::Dictionary::NBS_ISCC::S) perl(Color::Library::Dictionary::NBS_ISCC::SC) perl(Color::Library::Dictionary::NBS_ISCC::TC) perl(Color::Library::Dictionary::Netscape) perl(Color::Library::Dictionary::SVG) perl(Color::Library::Dictionary::Tango) perl(Color::Library::Dictionary::VACCC) perl(Color::Library::Dictionary::WWW) perl(Color::Library::Dictionary::Windows) perl(Color::Library::Dictionary::X11) Requires: perl(Color::Library) perl(Color::Library::Color) perl(Color::Library::Dictionary) perl(Module::Pluggable) perl(base) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review