https://bugzilla.redhat.com/show_bug.cgi?id=2309201 --- Comment #5 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Susi Lehtola from comment #3) > Package Review > ============== > > Fix the license field, and have a look at the hidden files. > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: python3-pytest7 is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ I believe this is a false positive. "BuildRequires: python3-pytest" installs correct pytest versions on every actual Fedora distribution. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "Apache License 2.0", "MIT License", > "*No copyright* Apache License and/or MIT License", "*No copyright* > MIT License". 55 files have unknown license. > => license field should read "MIT and Apache-2.0", see > https://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Combined_Dual_and_Multiple_Licensing_Scenario This is a valid issue indeed. A part of the library is generated from libsecp256k1 headers which are distributed unded MIT. The rest (python code) is licensed under MIT or Apache-2.0. So I believe the proper license tag is "MIT and (MIT or Apache-2.0)" > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. Done. > python3-coincurve.x86_64: W: hidden-file-or-dir > /usr/share/doc/python3-coincurve/docs/.scripts > python3-coincurve.x86_64: W: hidden-file-or-dir > /usr/share/doc/python3-coincurve/docs/.scripts > python3-coincurve.x86_64: W: hidden-file-or-dir > /usr/share/doc/python3-coincurve/docs/.snippets > python3-coincurve.x86_64: W: hidden-file-or-dir > /usr/share/doc/python3-coincurve/docs/.snippets > ============================================= 3 packages and 0 specfiles > checked; 0 errors, 4 warnings, 13 filtered, 0 badness; has taken 1.2 s > ============================================== Done. Also commented all patches. The same links: Spec URL: https://peter.fedorapeople.org/packages/python-coincurve.spec SRPM URL: https://peter.fedorapeople.org/packages/python-coincurve-20.0.0-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2309201 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309201%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
