[Bug 2308917] Review Request: python-ipfshttpclient - A Python client library for the IPFS API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2308917



--- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
(In reply to Susi Lehtola from comment #3)
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> 
> Issues:
> =======
> - Package must not depend on deprecated() packages.
>   Note: python3-pytest7 is deprecated, you must not depend on it.
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/deprecating-packages/

I believe this is a false positive. "BuildRequires: python3-pytest" installs
correct pytest versions on every actual Fedora distribution.

> 
> - The patches should be documented in comments. The comments should also
> make clear if the patches 1) come from upstream, 2) have been upstreamed, or
> 3) are Fedora specific.

Done.

The same links:

Spec URL: https://peter.fedorapeople.org/packages/python-ipfshttpclient.spec
SRPM URL:
https://peter.fedorapeople.org/packages/python-ipfshttpclient-0.8.0-0.1.a2.fc40.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2308917

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308917%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux