https://bugzilla.redhat.com/show_bug.cgi?id=2149698 --- Comment #29 from Caleb Maclennan <caleb@xxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [-]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [!]: License file installed when any subpackage combination is installed. [?]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 171483 bytes in 4 files. [?]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libtexpdf , libtexpdf-devel [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 6287360 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: sile-0.14.17-1.fc40.x86_64.rpm libtexpdf-0.14.17-1.fc40.x86_64.rpm libtexpdf-devel-0.14.17-1.fc40.x86_64.rpm sile-debuginfo-0.14.17-1.fc40.x86_64.rpm sile-debugsource-0.14.17-1.fc40.x86_64.rpm sile-0.14.17-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0izuq0ye')] checks: 31, packages: 6 sile.x86_64: E: zero-length /usr/share/sile/i18n/gu.ftl sile.x86_64: E: zero-length /usr/share/sile/i18n/jv.ftl sile.x86_64: E: zero-length /usr/share/sile/i18n/my.ftl sile.x86_64: E: zero-length /usr/share/sile/i18n/or.ftl sile.x86_64: E: zero-length /usr/share/sile/i18n/pa.ftl sile.x86_64: E: zero-length /usr/share/sile/i18n/sa.ftl sile.spec:66: W: unversioned-explicit-provides bundled(lua-lunamark) sile.spec: E: specfile-error error: %changelog entries must start with * libtexpdf.x86_64: E: no-changelogname-tag libtexpdf-devel.x86_64: E: no-changelogname-tag sile.src: E: no-changelogname-tag sile.x86_64: E: no-changelogname-tag sile-debuginfo.x86_64: E: no-changelogname-tag sile-debugsource.x86_64: E: no-changelogname-tag sile.src: W: name-repeated-in-summary SILE sile.x86_64: W: name-repeated-in-summary SILE sile.spec:128: W: macro-in-%changelog %autorelease libtexpdf.x86_64: W: invalid-license GPL-2.0 libtexpdf-devel.x86_64: W: invalid-license GPL-2.0 libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/agl.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/bmpimage.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cff.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cff_dict.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cff_limits.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cff_stdstr.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cff_types.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cid.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cid_basefont.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cid_p.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cidtype0.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cidtype2.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cmap.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cmap_p.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cmap_read.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cmap_write.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/cs_type2.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/dpxcrypt.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/dpxfile.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/dpxutil.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/epdf.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/error.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/fontmap.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/jp2image.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/jpegimage.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/mem.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/mfileio.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/numbers.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/otl_conf.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/otl_opt.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfcolor.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfdev.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfdoc.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfdraw.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfencoding.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfencrypt.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdffont.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdflimits.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfnames.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfobj.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfparse.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfresource.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pdfximage.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pkfont.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pngimage.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pst.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/pst_obj.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/sfnt.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/subfont.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/tfm.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/truetype.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/tt_aux.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/tt_cmap.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/tt_glyf.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/tt_gsub.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/tt_post.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/tt_table.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/type0.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/type1.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/type1c.h libtexpdf-devel.x86_64: E: incorrect-fsf-address /usr/include/libtexpdf/unicode.h sile.x86_64: W: files-duplicate /usr/share/sile/i18n/sk.ftl /usr/share/sile/i18n/cs.ftl sile.x86_64: W: files-duplicate /usr/share/sile/i18n/el.ftl /usr/share/sile/i18n/el-monoton.ftl:/usr/share/sile/i18n/el-polyton.ftl sile.x86_64: W: files-duplicate /usr/share/sile/i18n/no.ftl /usr/share/sile/i18n/nb.ftl sile.x86_64: E: explicit-lib-dependency lua-zlib 6 packages and 0 specfiles checked; 75 errors, 9 warnings, 75 badness; has taken 1.0 s Rpmlint (debuginfo) ------------------- Checking: sile-debuginfo-0.14.17-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphpm1618h')] checks: 31, packages: 1 sile-debuginfo.x86_64: E: no-changelogname-tag 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "libtexpdf". (none): E: there is no installed rpm "libtexpdf-devel". (none): E: there is no installed rpm "sile-debugsource". (none): E: there is no installed rpm "sile". (none): E: there is no installed rpm "sile-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- sile: /usr/lib64/sile/fontmetrics.so sile: /usr/lib64/sile/justenoughfontconfig.so sile: /usr/lib64/sile/justenoughharfbuzz.so sile: /usr/lib64/sile/justenoughicu.so sile: /usr/lib64/sile/justenoughlibtexpdf.so sile: /usr/lib64/sile/svg.so Source checksums ---------------- https://github.com/sile-typesetter/sile/releases/download/v0.14.17/sile-0.14.17.tar.xz : CHECKSUM(SHA256) this package : 7f89bedecedabb5168250ad9dd80c09ed289c8e88c3d0d756d2d1d92ee065e04 CHECKSUM(SHA256) upstream package : 7f89bedecedabb5168250ad9dd80c09ed289c8e88c3d0d756d2d1d92ee065e04 Requires -------- sile (rpmlib, GLIBC filtered): libc.so.6()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libharfbuzz-subset.so.0()(64bit) libharfbuzz.so.0()(64bit) libicudata.so.74()(64bit) libicui18n.so.74()(64bit) libicuio.so.74()(64bit) libicuuc.so.74()(64bit) liblua-5.4.so()(64bit) libm.so.6()(64bit) libtexpdf(x86-64) libtexpdf.so.0()(64bit) lua-cassowary lua-cldr lua-cliargs lua-cosmo lua-expat lua-filesystem lua-fluent lua-linenoise lua-loadkit lua-lpeg lua-luarepl lua-luautf8 lua-penlight lua-sec lua-socket lua-vstruct lua-zlib rtld(GNU_HASH) libtexpdf (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) libtexpdf-devel (rpmlib, GLIBC filtered): libtexpdf(x86-64) libtexpdf.so.0()(64bit) sile-debuginfo (rpmlib, GLIBC filtered): sile-debugsource (rpmlib, GLIBC filtered): Provides -------- sile: bundled(lua-lunamark) sile sile(x86-64) libtexpdf: libtexpdf libtexpdf(x86-64) libtexpdf.so.0()(64bit) libtexpdf-devel: libtexpdf-devel libtexpdf-devel(x86-64) sile-debuginfo: debuginfo(build-id) sile-debuginfo sile-debuginfo(x86-64) sile-debugsource: sile-debugsource sile-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name sile --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Java, PHP, fonts, R, Ocaml, Python, SugarActivity, Haskell, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH ---- Reviewer comments: * Package license file missing in libtexpf * License identifier for libtexpdf should be GPL-2.0-only * Latest upstream version of SILE is v0.15.5, but packaging the latest non-Rust based version first makes sense, and all the Lua dependencies are already provided. Bumping to the Rust based wrapper after the Lua based package works makes perfect sense in this case (as most of the Lua dependencies will be required the same way). * Does an exception need to be discussed for the bundled lua-lunamark (upstream bundled version is actually a fork)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202149698%23c29 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
