[Bug 2307912] Review Request: pyliblo3 - Python bindings for the liblo Open Sound Control (OSC) library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2307912



--- Comment #12 from Cristian Le <fedora@xxxxxxxxx> ---
Thanks Martin. My knowledge of direct cython interface is very limited since I
usually interface with it via CMake, but the following seems to work 

```
%prep
%autosetup -p1 -n pyliblo3-%{commit0}
# Remove pregenerated Cython C sources and build it again
rm -rf pyliblo3/_liblo.c

%generate_buildrequires
%pyproject_buildrequires

%build
cython -I pyliblo3 pyliblo3/_liblo.pyx
%pyproject_wheel

%install
%py3_shebang_fix .
%pyproject_install
%pyproject_save_files pyliblo3

mkdir -p %{buildroot}%{_mandir}/man1
cp scripts/dump_osc.1 %{buildroot}%{_mandir}/man1/
cp scripts/send_osc.1 %{buildroot}%{_mandir}/man1/

%check
%{py3_test_envvars} %{python3} -P -m unittest discover -s ./test -p '*.py'
```

The issue was that you were compiling the `.pyd` instead of the `.pyx` (don't
ask me the difference between those, I think it's like header/source).

I've also moved the parts a bit because the cython compilation is technically a
build step. `%py3_shebang_fix` could be anywhere, but I think it's common to be
in `%install` or `%build`


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2307912

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307912%23c12

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux