Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gd https://bugzilla.redhat.com/show_bug.cgi?id=225786 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NEXTRELEASE | ------- Additional Comments From pertusus@xxxxxxx 2008-01-28 16:25 EST ------- I haven't seen any file under the GPL. (There is one which is more bsd than mit, but it doesn't matter much). I suggest adding NEWS to %doc. Also I suggest adding INSTALL='install -p' to make install line to keep timestamps. I suggest removing the -f for rm such that it fails if files doesn't exist anymore: rm $RPM_BUILD_ROOT/%{_libdir}/libgd.la rm $RPM_BUILD_ROOT/%{_libdir}/libgd.a In case you didn't know, rpmlint says: gd.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 16) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review