https://bugzilla.redhat.com/show_bug.cgi?id=2309263 --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Version: 0^%{date}git%{shortcommit} This should be a tilde instead of a carat as there is no tagged version so it's technically even a pre-release of v0 > %if %{with check} > BuildRequires: gmock-devel > BuildRequires: gtest-devel > %endif > BuildRequires: libdrm-devel > BuildRequires: libevdev-devel > BuildRequires: libxcb-devel > BuildRequires: libxkbcommon-devel > BuildRequires: mesa-libgbm-devel > BuildRequires: pixman-devel > BuildRequires: protobuf-devel > BuildRequires: wayland-devel It looks like from the meson files that it uses pkgconfig references for these, so please convert these to "pkgconfig()" dependencies accordingly. > %build > pushd vm_tools/sommelier > %meson \ > -Dgamepad=true \ > -Dquirks=true \ > %if %{with tracing} > -Dtracing=true \ > %endif > %if %{without check} > -Dwith_tests=false \ > %endif > %{nil} > %meson_build > > %install > pushd vm_tools/sommelier > %meson_install > > %if %{with check} > %check > pushd vm_tools/sommelier > %meson_test > %endif It looks like you're missing "popd" for each of these "pushd" stanzas. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2309263 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309263%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
