[Bug 2307912] Review Request: pyliblo3 - Python bindings for the liblo Open Sound Control (OSC) library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2307912



--- Comment #10 from Cristian Le <fedora@xxxxxxxxx> ---
I did a bit more digging on this, and I think this is an issue with the
`__init__.py` file. If I replace it with a more standard format like:

```python
from ._liblo import *
```

and it seems to work better when I run it in the mock environment. I think the
culprit here is `from __future__ import absolute_import`, but it seemed to
still have worked after installing.
I believe you would find the same issue if you ran `%pyproject_check_import`.

As for the tox approach, I am not certain that the tests actually ran
appropriately, and it feels wrong to add a tox dependency for this.

Can you try 2 more things one after another?
- Configure `unittest` check to discover only within the `test` folder and with
a more relevant file selection: 
```
%check
%{py3_test_envvars} %{python3} -P -m unittest discover -s ./test -p "*.py" 
```
(see python3 -m unittest discover --help for more details on why those flags)

- If that didn't work try to also fix the `pyliblo3/__init__.py` to have the
minimal form as I've shown at the beginning.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2307912

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307912%23c10

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux