https://bugzilla.redhat.com/show_bug.cgi?id=2305524 --- Comment #10 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Bryan Gurney from comment #9) > Ok; thanks, Fabio. > > One other question, since I still haven't used rpmautospec enough to be > familiar with it: is this item OK to pass, given the header of the spec file? > > (head of rust-futures-locks.spec:) > --- > ## START: Set by rpmautospec > ## (rpmautospec version 0.6.5) > ## RPMAUTOSPEC: autorelease, autochangelog > %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: > release_number = 1; > base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); > print(release_number + base_release_number - 1); > }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} > ## END: Set by rpmautospec > --- > > (This section is the only occurrence of "define" in the spec file.) This section should only be present in spec files that were already processed by rpmautospec, i.e. you're not looking at the original. In general, the spec file linked by the COPR build is not really suitable for doing a package review, since it's not necessarily the original / unprocessed version, but the one from inside the uploaded SRPM file. (having separately uploaded and viewable spec and SRPM files, as required for reviews, helps with this) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305524 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305524%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
