[Bug 2308406] Review Request: python-pymdown-extensions - Extension pack for Python Markdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2308406



--- Comment #4 from Michel Lind <michel@xxxxxxxxxxxxxxx> ---
This part:

# Needed for the tests to pass
BuildRequires:  python3-pygments >= 2.18.0

and

# Drop invalid entry that breaks the pyproject macros
sed -i '/\.\[extra\]/d' pyproject.toml

That's only needed on epel9 right?

Relevant part of pyproject.toml

This package

[project.optional-dependencies]
extra = [
    "Pygments>=2.12"
]

readme-renderer:

[project.optional-dependencies]
md = ["cmarkgfm>=0.8.0"]

and in the spec

https://src.fedoraproject.org/rpms/python-readme-renderer/blob/f16ef838aba0746508fc0d11879b7b267b722e39/f/python-readme-renderer.spec#_40

%pyproject_buildrequires -t -x md
                            -----
(readme-renderer did not have the EPEL9 issue you have here because on EPEL9
some of its dependencies are old enough that even on an older version that
still has setup.py, tests are already failing, so there's no point rebasing to
a newer version)

not sure it's worth conditionalizing the whole spec but maybe add a note that
those two sections are only needed because setuptools is too old in EL9 - the
entries themselves are not actually invalid


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2308406

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308406%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux