[Bug 2307912] Review Request: pyliblo3 - Python bindings for the liblo Open Sound Control (OSC) library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2307912



--- Comment #7 from Cristian Le <fedora@xxxxxxxxx> ---
(In reply to Adam Williamson from comment #5)
> I think not having "Provides: pyliblo" is probably correct, because it
> doesn't provide the Python library called 'liblo'. It provides a library
> called 'liblo3'. It's not, at least as stands, a drop-in replacement.
> Consumers have to adjust their imports, and can update the dependency at the
> same time.

Fair point I would revise it to removing both `Provides` and `Obsolutes`. Dnf
should automatically remove any transient dependencies by itself.

(In reply to MartinKG from comment #6)
> - BuildArch: noarch` for the top-level package, does not work either, then the message “Arch dependent binaries in noarch package” appears

Aaah, sorry I've had pure-python packages too much on my mind lately. It is
correct that the main package is archful, and the others are not.

> - using `%{py3_test_envars}` before `%python3 setup.py test` does not work

That is odd, could you post in the Fedora-python matrix channel what errors you
get there?

> - I didn't use `pypi_source` because I don't know how it works.

The guidelines example package has an example usage, but basically
```
Source:        %{pypi_source pyliblo3}
```
It would also make release-monitoring.org happy ;)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2307912

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307912%23c7

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux