https://bugzilla.redhat.com/show_bug.cgi?id=2305524 --- Comment #7 from Bryan Gurney <bgurney@xxxxxxxxxx> --- There's a number of items that I need to manually review (this is normal for package reviews), but there's one concern from the licensecheck scan: The output of "licensecheck.txt" shows the following: --- *No copyright* Apache License 2.0 --------------------------------- rust-futures-locks-0.7.1-build/futures-locks-0.7.1/LICENSE-APACHE MIT License ----------- rust-futures-locks-0.7.1-build/futures-locks-0.7.1/LICENSE-MIT Unknown or generated -------------------- rust-futures-locks-0.7.1-build/futures-locks-0.7.1/.cargo_vcs_info.json rust-futures-locks-0.7.1-build/futures-locks-0.7.1/CHANGELOG.md rust-futures-locks-0.7.1-build/futures-locks-0.7.1/Cargo.toml rust-futures-locks-0.7.1-build/futures-locks-0.7.1/Cargo.toml.orig rust-futures-locks-0.7.1-build/futures-locks-0.7.1/README.md rust-futures-locks-0.7.1-build/futures-locks-0.7.1/src/lib.rs rust-futures-locks-0.7.1-build/futures-locks-0.7.1/src/mutex.rs rust-futures-locks-0.7.1-build/futures-locks-0.7.1/src/rwlock.rs rust-futures-locks-0.7.1-build/futures-locks-0.7.1/tests/mutex.rs rust-futures-locks-0.7.1-build/futures-locks-0.7.1/tests/rwlock.rs rust-futures-locks-0.7.1-build/futures-locks-0.7.1/tests/test.rs None of the 6 source files have license headers, but there are license files for Apache 2.0 and MIT. Are those license files enough to establish the software license, or do the upstream files need to have an Apache 2.0 header applied (as suggested by LICENSE-APACHE)? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305524 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305524%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
