https://bugzilla.redhat.com/show_bug.cgi?id=2307912 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx --- Comment #4 from Cristian Le <fedora@xxxxxxxxx> --- - With `%pyproject_buildrequires` please remove all of the other `BuildRequires: python3-` (other than `python3-devel`). Also `-r` flag has no effect [1] - Please put a note of why the commit is used there, or consider using the `pypi_source` instead `0.16.2` verison there was released on 2024/07/31. Should also contact upstream to encourage to tag the releases accordingly - Why the `chmod -x` on text files? - You should use `%{py3_test_envvars}` before the `%python3 setup.py test` [2] - Instead of manually populating `%{python3_sitearch}/pyliblo3/` use `-f %{pyproject_files}` and `%pyproject_save_files pyliblo3`. You would probably need an `%exclude` if you want `pyliblo3-tools` to be separate - Don't you want `Provides: pyliblo` in this case in order to have an upgrade path? - If you go with `pypi_source` consider also having `rpm-autospec` macros - You do not have a `BuildArch: noarch` for the top-level package (probably would also not need for subpackages as well afterwards?) [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#pyproject_buildrequires [2]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_other_test_runners -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2307912 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307912%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
