[Bug 2308057] Review Request: golang-github-gotk3 - Go bindings for GTK3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2308057



--- Comment #7 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Jonathan Steffan from comment #6)
> [!]: Package does not own files or directories owned by other packages.
>      Note: Dirs in package are owned also by:
>      /usr/share/gocode/src/github.com
> 
> This looks to be normal. I just wanted to check.
> 
> [!]: Requires correct, justified where necessary.
> 
> With the lower resolution requires for go packages, should we add these BRs
> versions?:
> 
> GTK 3 (3.12 and later)
> GDK 3 (3.12 and later)
> GLib 2 (2.36 and later)
> Cairo (1.10 and later)
> 
> 

It is impossible to reach that low in any supported Fedora/RHEL version, so I
don't think so.

> golang-github-gotk3-devel.noarch: E: zero-length
> /usr/share/gocode/src/github.com/gotk3/gotk3/pango/pangocairo.go.h
> 
> Not sure what to do here.
> 

Ignore it. I'm pretty sure this is a thing with Go generated header files.

> golang-github-gotk3-devel.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/golang-github-gotk3-devel/README.md
> 
> Run dos2unix and preserve timestamps.
> 

I can do that on import.

> golang-github-gotk3.spec: W: no-%build-section
> 
> I've not seen this one before. Is what it's looking for hidden in a macro?
> 

Yes.

> golang-github-gotk3-devel.noarch: W: hidden-file-or-dir
> /usr/share/gocode/src/github.com/gotk3/gotk3/.goipath
> 
> Does this need to be included for go packages?

It's made by the go2rpm machinery, so probably yes.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2308057

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202308057%23c7

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux