https://bugzilla.redhat.com/show_bug.cgi?id=2307912 Adam Williamson <awilliam@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Adam Williamson <awilliam@xxxxxxxxxx> --- I don't like the uncommented, opaquely-named patch: "fix_liblo3.patch". What does it fix? What is its upstream status? All patches should have a comment line that provides a brief explanation of what they're for, a comment line linking to a bug/issue report, and either a comment line linking to an upstream PR or a comment line explaining why there isn't one. As this is a new package, unless it's intended to also be built for EPEL 8, it might be nice to follow the modern Python guidelines using the pyproject macros, if they work for this project: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2307912 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307912%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
