https://bugzilla.redhat.com/show_bug.cgi?id=2307641 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks good to me - with two small exceptions. 1. Can you replace this: ``` %doc %{crate_instdir}/README.md %{crate_instdir}/ %license LICENSE ``` with this: ``` %license %{crate_instdir}/LICENSE %doc %{crate_instdir}/README.md %{crate_instdir}/ ``` Otherwise the LICENSE file will end up duplicated in the built package (once in /usr/share/licenses/rust-google-cloud-metadata/LICENSE and once in /usr/share/cargo/registry/google-cloud-metadata-0.5.0/LICENSE). 2. It would also be great if you could file a PR at https://github.com/yoshidan/google-cloud-rust to ensure LICENSE files are included in all published crates of this project? The MIT license file requires that redistributed sources contain a copy of the license text, so including the text manually in packaging should only be a temporary workaround. Here's where I made similar changes in another project recently: https://github.com/rustls/rustls-platform-verifier/pull/110 PS: I wonder what you're packaging this for? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2307641 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202307641%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
