https://bugzilla.redhat.com/show_bug.cgi?id=2304967 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: * Package builds and installs * Package follows Fedora packaging guidelines * Licensing is correct and license files are captured Some nits: > %if 0%{?build_with_lto} > # LTO is the default > %else > %define _lto_cflags %{nil} > %endif This can be written more simply: > %if ! 0%{?build_with_lto} > # LTO is the default > %define _lto_cflags %{nil} > %endif Otherwise, this looks good. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2304967 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202304967%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
