https://bugzilla.redhat.com/show_bug.cgi?id=2230002 --- Comment #4 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- (In reply to Peter Lemenkov from comment #3) > Few notes: > > * Please add "BuildRequires: python3-devel". It is as `pkgconfig(python3)` in `python3...` subpackage. I prefer to use pkgconfig when it is possible instead of strict package name. > You may remove "BuildRequires: pyproject-rpm-macros". Done > * Please consider packaging latest 3.3.0. Done. > * No %check section. Why? Added ----------- EL9: https://koji.fedoraproject.org/koji/taskinfo?taskID=122304811 F40: https://koji.fedoraproject.org/koji/taskinfo?taskID=122304952 F41: https://koji.fedoraproject.org/koji/taskinfo?taskID=122304955 F42: https://koji.fedoraproject.org/koji/taskinfo?taskID=122304960 SRPM: https://tieugene.fedorapeople.org/rpms/python-pamqp/python-pamqp-3.3.0-1.fc40.src.rpm Old SPEC: https://tieugene.fedorapeople.org/rpms/python-pamqp/python-pamqp-3.2.1-1.spec Actual SPEC: https://tieugene.fedorapeople.org/rpms/python-pamqp/python-pamqp.spec Spec diff: ```diff -- python-pamqp-3.2.1-1.spec 2023-08-08 15:51:41.000000000 +0300 +++ python-pamqp.spec 2024-08-22 14:38:48.218593745 +0300 @@ -1,13 +1,12 @@ %global module pamqp Name: python-%{module} -Version: 3.2.1 +Version: 3.3.0 Release: 1%{?dist} License: BSD-3-Clause Summary: AMQP 0-9-1 library URL: https://github.com/gmr/%{module} Source0: %{url}/archive/refs/tags/%{version}.tar.gz#/%{module}-%{version}.tar.gz BuildArch: noarch -BuildRequires: pyproject-rpm-macros %description pamqp is a low level AMQP 0-9-1 frame encoding and decoding library for Python3. @@ -20,6 +19,8 @@ BuildRequires: pkgconfig(python3) # python3-wheel BuildRequires: %{py3_dist wheel} +# python3-pytest +BuildRequires: %{py3_dist pytest} %{?python_provide:%python_provide python3-%{module}} %description -n python3-%{module} @@ -43,11 +44,20 @@ %pyproject_save_files %{module} +%check +%{pytest} + + %files -n python3-%{module} -f %{pyproject_files} %doc README.rst %license LICENSE %changelog +* Thu Aug 22 2024 TI_Eugene <ti.eugene@xxxxxxxxx> - 3.3.0-1 +- Version bump +- BR pyproject-rpm-macros removed +- Check section added + * Tue Aug 08 2023 TI_Eugene <ti.eugene@xxxxxxxxx> - 3.2.1-1 - Initial packaging ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2230002 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202230002%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
