https://bugzilla.redhat.com/show_bug.cgi?id=2306884 me@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |me@xxxxxxxxxxx --- Comment #2 from me@xxxxxxxxxxx --- As per #devel:fedoraproject.org discussion, the `cmake` BuildRequires can be dropped: https://copr.fedorainfracloud.org/coprs/samcday/wayqt/build/7932232/ Additionally the `cmake(Qt6Foo)` build-deps could also be changed to `pkgconfig(Qt6Foo)`, which is perhaps more appropriate? Finally, `fedpkg lint` is complaining about line length on pkgdesc, I propose this alternative: ``` %global _description \ A Qt-based library to handle Wayland and Wlroots protocols, to be used with \ any Qt project. \ Wayfire's private protocol is also supported. As the project develops, support \ for custom protocols may be added. \ ``` I lack the necessary permissions to set the Whiteboard status for these early nits. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2306884 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202306884%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue