https://bugzilla.redhat.com/show_bug.cgi?id=2304209 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Jerry James from comment #2) > Package Review > ============== Thank you! > Issues: > ======= > - Regarding the license, libstdlib/src/stub.sol has an Apache-2.0 comment at > the top. Are the contents of libstdlib included in the binary rpm? > > - The declared license is GPL-3.0-only, but most source files contain the > "any later version" language, for example: > - liblangutil/Common.h > - libsolc/libsolc.h > - solc/main.cpp I've started discussing licensing tags and terms with upstream (https://github.com/ethereum/solidity/issues/15353). Meanwhile I've changed License tag to "GPL-3.0-or-later and MIT". > - Some source files are derived from V8 and carry a BSD-3-Clause declaration, > in addition to the GPL-3.0-or-later declaration: > - liblangutil/CharStream.{cpp,h} > - liblangutil/Scanner.{cpp,h} > - liblangutil/Token.{cpp,h} These ones looks like relicensed to GPL-3.0-or-later. > - Also, libsolutil/picosha2.h has an MIT declaration Yes, I've added MIT to the license field. > - Not necessarily an issue, but I want to make sure you know that upstream > overrides the Fedora choice of -O2, adding -O3 to the build flags Fixed it. Will discuss it with upstream later. > - I don't know how seriously we take the "American English" thing, but I will > note that "behaviour" in %description is the British English spelling. We > lazy Americans drop the "u": "behavior". (See the spelling-error rpmlint > warning below.) Done. > - Is there any hope of doing something useful in %check; e.g., run the binary > with some simple input just to verify that it doesn't crash? Unfortunately not now. > - Please consider generating man pages with help2man (see the > no-manual-page-for-binary warning below) Done. The same links: Spec URL: https://peter.fedorapeople.org/packages/solidity.spec SRPM URL: https://peter.fedorapeople.org/packages/solidity-0.8.26-1.fc40.src.rpm Koji scratch build for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=122281998 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2304209 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202304209%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
