https://bugzilla.redhat.com/show_bug.cgi?id=2305930 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |quantum.analyst@xxxxxxxxx --- Comment #1 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- It would be best to use the modern Python packaging macros, which automate many of the manual things here.: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > %global pypi_version 0.6.3 This is mostly redundant; if you set `Version: 0.6.3`, it automatically generates a %{version} macro. > Source0: https://files.pythonhosted.org/packages/source/b/%{pypi_name}/btrfs_backup_ng-%{pypi_version}.tar.gz No need to number a single Source; can use the %pypi_source macro for the URL. > BuildRequires: python3dist(setuptools) Use %pyproject_buildrequires to autogenerate dependencies. > Summary: %{summary} Redundant. > Requires: python3dist(rich) > Requires: python3dist(setuptools) These are automatically determined by project metadata; no need to specify the manually. > %py3_build The modern macro is %pyproject_wheel. > %py3_install The modern macro is %pyproject_install. > %{python3_sitelib}/btrfs_backup_ng > %{python3_sitelib}/btrfs_backup_ng-%{pypi_version}-py%{python3_version}.egg-info You can use %pyproject_save_files to pick these up automatically. Are there any tests that could be run? Consider at least %pyproject_check_import. Also, consider using %autorelease and %autochangelog. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305930 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305930%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
