https://bugzilla.redhat.com/show_bug.cgi?id=2264719 --- Comment #8 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- Thank you for a thorough review. I hope I addressed all issues now. > 1) Sources I tried to use your suggestion, but the make file hard-except git checkout with submodules. So the tarball from tag does not work. Not even git-archive or git-archive-all because the Makefile does git operation in the checkout so you need .git directory too. At the end I created the tarball manually. > 2) License It is now correctly listed as %license > 3) Documentation Done. Although 'make install' leaves various files on various places, so I had to correct it at the end of %install section to comply with Fedora standards. > 4) Check I discovered that it has option --test. Added. > 5) Reporting issues to upstream The makefile is a mess. I plan to report it later to upstream case by case and provide PRs. But I did not have done it yet. > 6) Requirements ksh is only in bechmark.ksh. As a counterpart to benchmark.sh. I never run it. The /usr/bin/ksh is added by some automation. Even when I add ksh as weak deps. Should I filter it out? I added deps on bash and few other packages. Some of them as weak deps. But most of them are not needed. The code check for availability and should not fail when not available. Spec URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07921582-blesh/blesh.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/msuchy/package-review/fedora-rawhide-x86_64/07921582-blesh/blesh-0.4.0~devel3-3.fc42.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2264719 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264719%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
