Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libgee - GObject collection library https://bugzilla.redhat.com/show_bug.cgi?id=430351 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-01-27 23:17 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url a3db8d02ec106df97c4f36257a7b5e8a libgee-0.1.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + gee-1.0.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libgee-0.1.1-2.fc9 -> Provides: libgee.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libgee.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 rtld(GNU_HASH) + Package libgee-devel-0.1.1-2.fc9 -> Requires: libgee = 0.1.1-2.fc9 libgee.so.0 pkgconfig vala + Not a GUI App. I also don't think good to create one more subpackage for installing single file. Good that you already commented same in SPEC file. SHOULD: Add ChangeLog to libgee package also. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review