https://bugzilla.redhat.com/show_bug.cgi?id=2305343 Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zonexpertconsulting@outlook | |.com Doc Type|--- |If docs needed, set a value --- Comment #1 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> --- Hi Felix, short answer is yes. I'll review this for you. I'll run fedora-review as soon as I can. Some preliminary notes: Minor spellcheck in libimagevisualresult-data subpackage description: dat -> data You probably know, but this only builds on rawhide due to a couple dependencies that are missing in the other distros. Have you spent any time with the tests? For giggles, I made the following changes to build the package with tests turned on: https://github.com/knight-of-ni/specfiles/commit/f69342330eb8cc87d31d0e3eadcdf3a657d9b367 That's when I realized that the tests don't seem to be configured properly to actually run during the build. That's where I stopped. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305343 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305343%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
