[Bug 2244677] Review Request: mactelnet - MikroTik MAC-Telnet protocol tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2244677



--- Comment #12 from Petr Menšík <pemensik@xxxxxxxxxx> ---
Why is this package mactelnet btw, when upstream archive name is MAC-Telnet? It
would be okay to lowercase, that is even recommended by upstream. It should be
mac-telnet IMO. According to
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ at least.

btw you can use %{url} in Source0, so its value would become Source0:       
%{url}/archive/refs/tags/v%{version}/MAC-Telnet-%{version}.tar.gz

Otherwise, it looks good.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2244677

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244677%23c12

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux