https://bugzilla.redhat.com/show_bug.cgi?id=2296791 Jens Petersen <petersen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ URL|https://hackage.haskell.org |https://hackage.haskell.org |/package/%{pkg_name} |/package/config-schema Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |petersen@xxxxxxxxxx --- Comment #3 from Jens Petersen <petersen@xxxxxxxxxx> --- Looks fine to me - No serious differences with cabal-rpm spec - I did notice in a few of the reviews (including this one) where the .cabal file gets revised, you don't use dos2unix to convert the revised .cabal to unix line endings. I don't think it is too serious, but iirc it is required, so better to do so. Could this be some kind of cabal-rpm bug? It works for me anyway: I wondered why you aren't getting that: I put the cabal-rpm diff output below for reference. - License is ISC and package complies with Packaging Guidelines - builds and installs fine Package is APPROVED $ cabal-rpm diff ghc-config-schema --- ghc-config-schema.spec 2024-07-09 08:00:00.000000000 +0800 +++ ghc-config-schema.spec.cblrpm 2024-08-16 00:26:52.768187444 +0800 : Source1: https://hackage.haskell.org/package/%{pkgver}/%{pkg_name}.cabal#/%{pkgver}.cabal # End cabal-rpm sources # Begin cabal-rpm deps: +BuildRequires: dos2unix BuildRequires: ghc-Cabal-devel BuildRequires: ghc-rpm-macros BuildRequires: ghc-base-devel @@ -89,7 +90,7 @@ %prep # Begin cabal-rpm setup: %setup -q -n %{pkgver} -cp -bp %{SOURCE1} %{pkg_name}.cabal +dos2unix -k -n %{SOURCE1} %{pkg_name}.cabal # End cabal-rpm setup -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2296791 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202296791%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
