https://bugzilla.redhat.com/show_bug.cgi?id=2299656 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- This package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "FSF Unlimited License [generated file]". 71 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2299656-erlang- esip/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7483 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: erlang-esip-1.0.54-2.fc41.x86_64.rpm erlang-esip-debuginfo-1.0.54-2.fc41.x86_64.rpm erlang-esip-debugsource-1.0.54-2.fc41.x86_64.rpm erlang-esip-1.0.54-2.fc41.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp9gcxkmg')] checks: 32, packages: 4 erlang-esip.x86_64: W: no-soname /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_app.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_app.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_client_transaction.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_client_transaction.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_codec.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_codec.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_dialog.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_dialog.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_listener.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_listener.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_server_transaction.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_server_transaction.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_socket.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_socket.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_sup.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_sup.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_tmp_sup.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_tmp_sup.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_transaction.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_transaction.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_transport.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_transport.erl erlang-esip.x86_64: W: beam-was-not-recompiled /usr/lib64/erlang/lib/esip-1.0.54/ebin/esip_udp_sup.beam /builddir/build/BUILD/erlang-esip-1.0.54-build/esip-1.0.54/src/esip_udp_sup.erl ========== 4 packages and 0 specfiles checked; 0 errors, 14 warnings, 24 filtered, 0 badness; has taken 0.3 s ========== Rpmlint (debuginfo) ------------------- Checking: erlang-esip-debuginfo-1.0.54-2.fc41.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6wdppiga')] checks: 32, packages: 1 =========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s =========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_alloc_binary (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_free (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_make_int (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_make_binary (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_make_atom (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_alloc (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_compare (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_get_int (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_make_list_cell (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_realloc (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_get_uint (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_make_badarg (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_inspect_iolist_as_binary (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: E: undefined-non-weak-symbol /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so enif_make_list (/usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so) erlang-esip.x86_64: W: no-soname /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so 3 packages and 0 specfiles checked; 14 errors, 1 warnings, 21 filtered, 14 badness; has taken 0.3 s Unversioned so-files -------------------- erlang-esip: /usr/lib64/erlang/lib/esip-1.0.54/priv/lib/esip_drv.so Source checksums ---------------- https://github.com/processone/esip/archive/1.0.54/esip-1.0.54.tar.gz : CHECKSUM(SHA256) this package : 9336f02ea99cfad359c78c50fdd9c3061aac7b31966abdc3223f56b3ed7cc377 CHECKSUM(SHA256) upstream package : 9336f02ea99cfad359c78c50fdd9c3061aac7b31966abdc3223f56b3ed7cc377 Requires -------- erlang-esip (rpmlib, GLIBC filtered): erlang(erl_nif_version) erlang-crypto(x86-64) erlang-erts(x86-64) erlang-fast_tls erlang-fast_tls(x86-64) erlang-inets(x86-64) erlang-kernel(x86-64) erlang-p1_utils erlang-stdlib(x86-64) erlang-stun erlang-tools(x86-64) libc.so.6()(64bit) rtld(GNU_HASH) erlang-esip-debuginfo (rpmlib, GLIBC filtered): erlang-esip-debugsource (rpmlib, GLIBC filtered): Provides -------- erlang-esip: erlang-esip erlang-esip(x86-64) erlang-p1_sip erlang-esip-debuginfo: debuginfo(build-id) erlang-esip-debuginfo erlang-esip-debuginfo(x86-64) erlang-esip-debugsource: erlang-esip-debugsource erlang-esip-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/2299656-erlang-esip/srpm/erlang-esip.spec 2024-08-14 16:22:28.728375278 -0600 +++ /home/jamesjer/2299656-erlang-esip/srpm-unpacked/erlang-esip.spec 2024-07-23 18:00:00.000000000 -0600 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.6.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 2; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global srcname esip @@ -64,3 +74,75 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Wed Jul 24 2024 Peter Lemenkov <lemenkov@xxxxxxxxx> - 1.0.54-2 +- Uncommitted changes + +* Wed Jul 24 2024 Peter Lemenkov <lemenkov@xxxxxxxxx> - 1.0.54-1 +- Unretire + +* Wed Jul 19 2023 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.37-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild + +* Thu Jan 19 2023 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.37-6 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild + +* Thu Jul 21 2022 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.37-5 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + +* Thu Jan 20 2022 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.37-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + +* Wed Jul 21 2021 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.37-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + +* Tue Jan 26 2021 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.37-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Fri Jul 31 2020 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 1.0.37 +- Update to 1.0.37 (#1807285). +- https://github.com/processone/esip/blob/1.0.37/CHANGELOG.md + +* Sat Aug 01 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.31-3 +- Second attempt - Rebuilt for + https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Mon Jul 27 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.31-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Mon Feb 17 2020 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 1.0.31-1 +- Update to 1.0.31 (#1789165). +- https://github.com/processone/esip/blob/1.0.31/CHANGELOG.md + +* Tue Jan 28 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.30-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + +* Tue Jan 07 2020 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 1.0.30-2 +- Drop the ExcludeArch on esip (#1772975). + +* Thu Nov 14 2019 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 1.0.30-1 +- Update to 1.0.30 (#1742453). +- https://github.com/processone/esip/blob/1.0.30/CHANGELOG.md +- Add an exclusion on s390x (#1770256). + +* Wed Jul 24 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.29-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + +* Wed Jun 05 2019 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 1.0.29-1 +- Update to 1.0.29 (#1713297). +- https://github.com/processone/esip/blob/1.0.29/CHANGELOG.md + +* Tue Apr 16 2019 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 1.0.28-1 +- Update to 1.0.28 (#1683113). +- https://github.com/processone/esip/blob/1.0.28/CHANGELOG.md + +* Thu Feb 21 2019 Peter Lemenkov <lemenkov@xxxxxxxxx> - 1.0.27-3 +- Rebuild for Erlang 21 + +* Thu Jan 31 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.0.27-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + +* Tue Jan 08 2019 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 1.0.27-1 +- Update to 1.0.27. +- https://github.com/processone/esip/blob/1.0.27/CHANGELOG.md + +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2299656 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Ocaml, Haskell, Java, fonts, Perl, R, PHP, Ruby, SugarActivity, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2299656 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299656%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
