https://bugzilla.redhat.com/show_bug.cgi?id=2303776 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lemenkov@xxxxxxxx | |m) | --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Michal Ambroz from comment #1) Thanks! > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Source1 is not specified with the downloadable link - quite possibly not > needed at all > I am missing any explanation why this particular snapshot for conftest.py is > used and not the one in the release v0.2.1 (it is present in the github > tarball). > Actually according the commit it is the very same version. Is this really > needed to be tracked separately? > If so then I would recommend at least changing it to this to be able to > download with "spectool -g": > Source1: > https://raw.githubusercontent.com/vyperlang/vvm/ > f7b4de84e070062eb4519b2fb5ab0ee8e72269e0/tests/conftest.py#/python-vvm- > conftest.py I've simplified things by switching to a GitHub tarball. > - VCS is not valid link. > The git:%{url}.git results in git:https://github.com/vyperlang/vvm.git, > which is not a valid link according to git: > > ``` > $ git clone git:https://github.com/vyperlang/vvm.git > Cloning into 'vvm'... > fatal: protocol 'git:https' is not supported > ``` > > I would recommend in this case just using the > https://github.com/vyperlang/vvm instead I believe it should kept as is. According to "RPM tags": ``` Format <vcs>:<address> with <vcs> being the VCS command used (e.g. git, svn, hg, …) and <address> being the location of the repository as used by the VCS tool to clone/checkout the repository (e.g. https://github.com/rpm-software-management/rpm.git). ``` https://rpm-software-management.github.io/rpm/manual/tags.html > Reccommendations > ================ > - Using the macros in the Name/URL flag is decreasing the readibility of the > SPEC file and is not even shorter. > I would recommend using > Name: python-vvm > URL: https://github.com/vyperlang/vvm > instead of: > Name: python-%{pypi_name} > URL: https://github.com/vyperlang/%{pypi_name} I believe you're right. I've fixed that and going to fix other my packages in the meantime. > - Package Description is same as Summary. > As a layman in this area I would probably appreciate some longer > explanation, like that it is a tooling > that it manages/installs the needed versions of vyper - contract-oriented, > Pythonic programming language > that targets the Ethereum Virtual Machine (EVM). Improved description a bit. A new package but the same links: Spec URL: https://peter.fedorapeople.org/packages/python-vvm.spec SRPM URL: https://peter.fedorapeople.org/packages/python-vvm-0.2.1-1.fc40.src.rpm Koji scratch build for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=121949070 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2303776 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202303776%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
