https://bugzilla.redhat.com/show_bug.cgi?id=2304063 --- Comment #4 from Sandro <gui1ty@xxxxxxxxxxxxx> --- I've looked into excluding the tests from the installation. Unfortunately, poetry, the build backend upstream is using, is broken in that regard [1]. So, let's leave that as is for now. It doesn't hurt having the tests installed and `%pyproject_check_import` also succeeds since `pytest` is installed anyway. Two more things you might want to consider. Those are recommended, but not required. 1. Add a provides for `zarrsum` Part of the package is an executable called `zarrsum`. In order for users to be able to install the package providing the executable, it is helpful to have a `Provides:` by the same name. You do that by adding Provides: zarrsum = %{version}-%{release} to the `python3-zarr-checksum` package. This will allow users to us `dnf install zarrsum` instead of having to know or figure out that `zarrsum` is part of `python3-zarr-checksum`. 2. Generate a man page for `zarrsum` This optional and the usefulness depends on the output of the script's `--help` option. For inspiration see: https://src.fedoraproject.org/rpms/fawltydeps/blob/rawhide/f/fawltydeps.spec You will need to add a BR for `help2man` as well as adding the man pages to the `%files` section. [1] https://github.com/python-poetry/poetry/issues/3380 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2304063 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202304063%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
