https://bugzilla.redhat.com/show_bug.cgi?id=2304228 Michel Lind <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- Mostly LGTM, APPROVED with some nits below Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 204 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/2304228-miracle-wm- config/licensecheck.txt => it's unclear if this is GPL-3.0-only or GPL-3.0-or-later. Miracle WM itself is GPL-3.0-or-later so that makes sense, but since you are upstream can you list that in either README.md or in file headers? [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/initial-setup, /usr/lib/sddm [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/libexec/initial-setup => looks like this should be owned by `initial-setup` but is not, please file a bug [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 222 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in initial- setup-gui-wayland-miraclewm , sddm-wayland-miraclewm [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: miracle-wm-config-0~git.1.20240812.486b4cb-1.fc41.noarch.rpm initial-setup-gui-wayland-miraclewm-0~git.1.20240812.486b4cb-1.fc41.noarch.rpm sddm-wayland-miraclewm-0~git.1.20240812.486b4cb-1.fc41.noarch.rpm miracle-wm-config-0~git.1.20240812.486b4cb-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpm_9x2l3g')] checks: 32, packages: 4 miracle-wm-config.spec:38: W: unversioned-explicit-provides firstboot(gui-backend) miracle-wm-config.spec:59: W: unversioned-explicit-provides sddm-greeter-displayserver sddm-wayland-miraclewm.noarch: W: only-non-binary-in-usr-lib initial-setup-gui-wayland-miraclewm.noarch: W: no-documentation sddm-wayland-miraclewm.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings, 16 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 sddm-wayland-miraclewm.noarch: W: only-non-binary-in-usr-lib sddm-wayland-miraclewm.noarch: W: no-documentation initial-setup-gui-wayland-miraclewm.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 3 warnings, 9 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://pagure.io/fedora-miracle/miracle-wm-config/archive/486b4cb6c48f85f2334d3808918e4f07fda69c5d/miracle-wm-config-486b4cb6c48f85f2334d3808918e4f07fda69c5d.tar.gz : CHECKSUM(SHA256) this package : fb562e8136e43762ce307c21153538a5e22becb52080f4a096b18b0f1a15c526 CHECKSUM(SHA256) upstream package : fb562e8136e43762ce307c21153538a5e22becb52080f4a096b18b0f1a15c526 Requires -------- miracle-wm-config (rpmlib, GLIBC filtered): desktop-backgrounds-compat miracle-wm swaybg swaylock initial-setup-gui-wayland-miraclewm (rpmlib, GLIBC filtered): /usr/bin/sh initial-setup-gui miracle-wm xorg-x11-server-Xwayland sddm-wayland-miraclewm (rpmlib, GLIBC filtered): desktop-backgrounds-compat layer-shell-qt miracle-wm sddm Provides -------- miracle-wm-config: miracle-wm-config initial-setup-gui-wayland-miraclewm: firstboot(gui-backend) initial-setup-gui-wayland-miraclewm sddm-wayland-miraclewm: sddm-greeter-displayserver sddm-wayland-miraclewm Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2304228 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api Disabled plugins: C/C++, Python, Perl, R, Java, Haskell, fonts, SugarActivity, PHP, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2304228 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202304228%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
