https://bugzilla.redhat.com/show_bug.cgi?id=2303653 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Jerry James from comment #2) > There are a few minor issues, but nothing worth blocking the review for. > Please take a look at them before importing. This package is APPROVED. Thanks! > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: python3-pytest7 is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ > > I don't remember what you did about this with the other python package of > yours I reviewed with this issue. "BuildRequires: python3-pytest" can be > satisfied with either the pytest 8 package or the deprecated pytest 7 > package. Exactly this. It pulls pytes8 where available. > - The %description does not convey much useful information. Please consider > copying a few paragraphs from README.rst. Will do. > - A SHOULD item: "Patches link to upstream bugs/comments/lists or are > otherwise > justified." Please add a comment about the patch in the spec file. Sure.That particular patch is taken from upstream (https://github.com/multiformats/py-multibase/pull/16) > - Please remove the dot at the end of the Summary in the python3 subpackage. > See the summary-ended-with-dot rpmlint warning below. Done. > > - %pyproject_check_import is not necessary when using %pytest; pytest will > effectively run the import check as it runs its tests Ah ok, that's a new to me. Will do the same with all my Python packages then. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2303653 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202303653%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
