[Bug 2299972] Review Request: bees - CLI tool and service for block level de-duplication in BTRFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2299972



--- Comment #11 from Jeremy Cline <jeremy@xxxxxxxxxx> ---
Sorry for the delay getting back to this (and thanks Neal for the review as
well)!

There's only one thing I spot, which is that the /etc/bees directory is
unowned[0]. You can mark it as part of the package by adding:

%{_sysconfdir}/%{name}/

Everything else looks solid to me.

Thanks for doing those reviews. My only notes are that the feedback from Ben in
https://bugzilla.redhat.com/show_bug.cgi?id=2302515#c4 is spot on and in the
future you'll want to do that.

Finally, thanks for sticking with the process! Once you address the unowned
directory, I'll give it one last look over, approve the package, and sponsor
you into the packager group.

[0]
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2299972

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299972%23c11

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux