Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: timidity++ https://bugzilla.redhat.com/show_bug.cgi?id=226492 ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-01-27 17:18 EST ------- Good news after lots of searching and negotiating with the author I've managed to find a soundfont that meets the content Guidelines for Fedora. I've already send the license past Spot and he has approved it. I've packages it and submitted it for review. Its review is bug 430417. Note that in order to convert the original .sf2 file to gus patch format (needed by SDL_mixer, allegro, libtimidity and wildmidi) a conversion utility is needed, its review is bug 430418. So if someone can give me a hand and review these can then we can get rid of the not licensed gus patches we are currently using. If you look at soundfont package, you will see that the spec file generates 2 packages: PersonalCopy-Lite-soundfont PersonalCopy-Lite-patches The first contains the pristine .sf2 file from upstream, the other contains the same file converted into GUS patch format. Timidity++ can handle both, and seems to do somehat better with the .sf2 format (for one timidity does not support multiple velocity layers when reading the patches in the gus format). So it would be best to make timidity depend upon the .sf2 format version. However that brings us to the question what todo with /etc/timidity.cfg, as already said: SDL_mixer, allegro, libtimidity and wildmidi all 4 only support the gus format, and they expect to be able to read a generalmidi mapping in gus format from /etc/timidity.cfg. So my proposed solution is to let the gus format package install /etc/timidity.cfg (and provide timidity++-patches, as that is required by the 4 listed above), and let the .sf2 format package install /etc/timidity-soundfont.cfg. I then combine this with a patch to timidity to first check for /etc/timidity-soundfont.conf and fallback to /etc/timidity.cfg if that is missing, and all is well. Any opinions / input on this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review