https://bugzilla.redhat.com/show_bug.cgi?id=2303280 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- The only thing I don't like is that upstream bundled a few loosely coupled projects into the same tarball. However anthough that's unfortunate it does not relate to Fedora. So here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (GPLv2+). [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception (see my notes above). [x]: Changelog in prescribed format (%autochangelog). [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2053 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [x]: Latest version is packaged (https://github.com/homalg-project/homalg_project/releases?q=4ti2Interface&expanded=true) [x]: Package does not include license text files separate from upstream. [-]: No extra patches. [-]: Sources were not verified with gpgverify (upstream doe not publish signatures). [?]: I did not test if the paackage compiles and builds into binary rpms on all supported architectures. Noarch package anyway. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gap-pkg-4ti2interface-2023.02.04-1.fc41.noarch.rpm gap-pkg-4ti2interface-doc-2023.02.04-1.fc41.noarch.rpm gap-pkg-4ti2interface-2023.02.04-1.fc41.src.rpm ========================================================================================================================================== rpmlint session starts ========================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5t2g_1g5')] checks: 32, packages: 3 gap-pkg-4ti2interface-doc.noarch: W: no-documentation gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/toggless.js ../../GAPDoc/styles/toggless.js ==================================================================================================== 3 packages and 0 specfiles checked; 0 errors, 11 warnings, 12 filtered, 0 badness; has taken 1.1 s ==================================================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 gap-pkg-4ti2interface-doc.noarch: W: no-documentation gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-4ti2interface-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/4ti2Interface/doc/toggless.js ../../GAPDoc/styles/toggless.js 2 packages and 0 specfiles checked; 0 errors, 11 warnings, 8 filtered, 0 badness; has taken 0.3 s Source checksums ---------------- https://github.com/homalg-project/homalg_project//archive/4ti2Interface-2023.02-04.tar.gz : CHECKSUM(SHA256) this package : a35c17b93a08e7d3b9bb989d22d8c99d8563dd32c338e336f3d42b6f12604e85 CHECKSUM(SHA256) upstream package : a35c17b93a08e7d3b9bb989d22d8c99d8563dd32c338e336f3d42b6f12604e85 Requires -------- gap-pkg-4ti2interface (rpmlib, GLIBC filtered): 4ti2 gap-pkg-io gap-pkg-4ti2interface-doc (rpmlib, GLIBC filtered): gap-pkg-4ti2interface Provides -------- gap-pkg-4ti2interface: gap-pkg-4ti2interface gap-pkg-4ti2interface-doc: gap-pkg-4ti2interface-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2303280 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, C/C++, Perl, SugarActivity, Java, Python, Ocaml, fonts, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH This package is ================ === APPROVED === ================ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2303280 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202303280%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
