https://bugzilla.redhat.com/show_bug.cgi?id=2295793 --- Comment #8 from Antoine Tenart <atenart@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #7) > Two minor issues: > > 1. It looks like you changed the License tag in the package from > LGPL-2.0-or-later to LGPL-2.1-or-later. > The latter matches the license text included in the package. > > Is this an actual issue in the crate? i.e. is LGPL-2.1-or-later the > intended license (I assume so)? > If this is the case, please file an issue with the upstream project about > fixing the license expression in the crate metadata. This is a known issue and I opened a PR some time ago, https://github.com/retis-org/btf-rs/pull/26. I pinged the other maintainers and it is merged now. > Additionally, to have automated tools for collecting license information > pick this fix up, you will need to use "rust2rpm -p" to patch Cargo.toml for > this change too - just editing the License tag in the generated spec file is > not enough in this case. OK, so Cargo.toml needs to be up to date for the tooling. Alternatively we can release a new upstream version with that fix included, IMO that would be even better. > 2. You dropped the subpackage corresponding to the "test_runtime" feature. > Why? > It has no additional dependencies, so I see no reason to hide this > feature on the RPM metadata side. It has no additional dependency but is a very specific feature. It enables tests requiring specific privileges (access to /sys/kernel/btf/*) instead of test files provided in the sources. There's really no use case for a consumer of that crate to use such feature (and looking at it again now we might even remove it in the future). Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2295793 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295793%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
