https://bugzilla.redhat.com/show_bug.cgi?id=2294718 --- Comment #21 from Jerry James <loganjerry@xxxxxxxxx> --- Sorry for the delay. This is looking much better! I think the metainfo problem is because the component type is "desktop". It should be "desktop-application" instead. According to the spec, the <id> tag should have the form tld.vendor.product. The tld is org, the vendor is yudit, and the product is also yudit, so I think the metainfo should contain <id>org.yudit.yudit</id>. The filenames should be based on the id, so that would be org.yudit.yudit.metainfo.xml for the AppData file and org.yudit.yudit.desktop for the desktop file. See https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic. Also, for the <update_contact> tag, I recommend against listing upstream's email address, since the metainfo file is a downstream addition. It should probably be yudit-maintainers@xxxxxxxxxxxxxxxxx (which won't exist until the package is created, of course). It would also be good to add <launchable type="desktop-id">org.yudit.yudit.desktop</launchable>, assuming you follow my recommendation for the desktop file name. It would would also be good to list the binaries, like this: <provides> <binary>mytool</binary> <binary>uniconv</binary> <binary>uniprint</binary> <binary>yudit</binary> </provides> Now for the fonts. Fonts are always a pain in the neck. I'm afraid we need to do more work to comply with the Font Policy (https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/). The OldHungarian and yudit fonts do not appear to be related to each other. That means that each font must be in a separate package, not bundled together in a "fonts" subpackage: https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_installation_rpm_package_break_up_font_packages. The OldHungarian font is under the CC-BY-SA-3.0 license. While that is an allowed license for content and documentation, it is not on the list of allowed licenses for fonts: https://docs.fedoraproject.org/en-US/legal/allowed-licenses/. Can you please file a ticket at https://gitlab.com/fedora/legal/fedora-license-data/-/issues and ask whether CC-BY-SA-3.0 is acceptable for fonts? The prebuilt font files are TTF, but the Fonts Policy requires that OTF files be shipped: https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_font_file_formats. The source for the OldHungarian font is in font-src/OldHungarian_Full.sfd, so it is possible to rebuild it as OTF. However, I do not see sources for the yudit font. Do you know if they are available somewhere? The TTF file appears to have been built with fontforge, which we have in Fedora. Furthermore, the yudit sources appear to be fixated on working with TTF files rather than OTF files. You will either need to patch yudit to use OTF files or ask for an exception to the font policy for this package. I'm not sure the *.hex files should be installed with the fonts, since they are not font files. I will have to think about that. Also, fonts/README.TXT says that yudit needs fonts that yudit upstream cannot redistribute, namely arial.ttf, kochi-gothic.ttf, gulim.ttf, cyberbit.ttf, caslr.ttf, and fogcaslr.ttf. If they are not redistributable, then Fedora cannot package them either. Will yudit have problems if these fonts are missing? Fontconfig files need to be provided for the fonts: https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_fontconfig_2 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2294718 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294718%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
