[Bug 2295805] Review Request: rust-derive-into-owned - Custom derives to help with types containing Cow fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2295805

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx



--- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> # FIXME: no license files detected

It looks like you used "rust2rpm --ignore-missing-license-files" *and* didn't
actually fix the FIXME?
The MIT license requires that redistributed sources contain a copy of the
license text.

It looks like the upstream project added a license file after publishing the
latest release:
https://github.com/koivunej/derive-into-owned

Please file an issue upstream about getting a new release that contains the
license text.
In the meantime, you can include the license file from GitHub as a separate
source.

For Rust packages, we usually handle this case like it is handled here:
https://src.fedoraproject.org/rpms/rust-backtrace-ext/blob/rawhide/f/rust-backtrace-ext.spec

(except that you only have one LICENSE file instead of LICENSE-APACHE and
LICENSE-MIT, of course)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2295805

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295805%23c5

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux