[Bug 2246704] Review Request: python-xlrd2 - Library to extract data from Microsoft Excel legacy spreadsheet files (xls)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2246704



--- Comment #10 from Michal Ambroz <rebus@xxxxxxxxx> ---
Hello Miroslave,
> And in the spec file there is nothing specifically requiring version 7.
explicit versioning it is not in the spec file and it is not in the package.
I do not understand this detection. Maybe it detects some deprecated API of
pytest ... donno?
Please how did you come to this detection? I do not see it in the review from
the Fedora review service.


>This is still not fixed.
I believe this is not really issue.
The file licenses.html is just part of the documentation package - rst rendered
to html based on licenses.rst.
File licenses.rst is itself just literally including the LICENSE file from
package base directory.
See https://github.com/DissectMalware/xlrd2/blob/master/docs/licenses.rst

It is not wrong that it is not marked as %license and that it is not in the
noarch package - source of the license information is the LICENSE file, which
is already marked as %license.
I believe the purpose of this rule is to have at least one
meaningfull/authoritative copy of the license marked as %license, not to mark
all rendered or otherwise derived copies. 
Frankly I would say that it is already wrong marking the documentation source
file doc/licenses.rst as %license.
Also it is wrong deleting of the
/usr/share/doc/python-xlrd2-doc/html/_sources/licenses.rst.txt ... as the html
rendered page is referring to that with a hyper-link to "Show source".

Best regards

Michal Ambroz


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2246704

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246704%23c10

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux