[Bug 2299173] Review Request: rust-virtio-vsock - Virtio vsock device implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2299173



--- Comment #31 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
One last thing - what is this about?

> %dir %{crate_instdir}
> %{crate_instdir}/src/
> %{crate_instdir}/*.toml
> %{crate_instdir}/.cargo-checksum.json
> %doc %{crate_instdir}/CHANGELOG.md
> %doc %{crate_instdir}/README.md
> %license %{crate_instdir}/LICENSE-APACHE
> %license %{crate_instdir}/LICENSE-BSD-3-Clause

This is much too verbose and will break in future updates.
It should look like this:

"""
%license %{crate_instdir}/LICENSE-APACHE
%license %{crate_instdir}/LICENSE-BSD-3-Clause
%doc %{crate_instdir}/CHANGELOG.md
%doc %{crate_instdir}/README.md
%{crate_instdir}/
"""

If you did the above change to work around the RPM warning that some files are
listed twice, then please don't.

The way rust2rpm generates this %files list is intentional, and works
correctly. I have confirmation from RPM upstream that the way this is done is
OK, and an acceptable workaround for limitations of RPM.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2299173

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299173%23c31

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux