https://bugzilla.redhat.com/show_bug.cgi?id=2292554 --- Comment #21 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks good to me too, just a suggestion for better metadata / integration with RPM dependencies: You might want to add Requires for the specific vte library versions for the features that depend on them. Something like this in rust2rpm.toml should work: ``` [requires] build = ["pkgconfig(vte-2.91-gtk4)"] lib = ["pkgconfig(vte-2.91-gtk4)"] features.v0_66 = ["pkgconfig(vte-2.91-gtk4) >= 0.66"] features.v0_70 = ["pkgconfig(vte-2.91-gtk4) >= 0.70"] features.v0_72 = ["pkgconfig(vte-2.91-gtk4) >= 0.72"] features.v0_74 = ["pkgconfig(vte-2.91-gtk4) >= 0.74"] ``` This happens often for GNOME-related library bindings. You can take a look at gtk4-sys for an example: https://src.fedoraproject.org/rpms/rust-gtk4-sys/blob/rawhide/f/rust2rpm.toml Adding these Requires explicitly should prevent some weird and / or hard to diagnose compiler failures when the vte library on the host is older than the one expected by the feature flags passed to the crate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2292554 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202292554%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
