https://bugzilla.redhat.com/show_bug.cgi?id=2301667 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@xxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- A few suggestions: > Group: System Environment/Libraries Not required > License: GPLv3+ Use SPDX short identifier: GPL-3.0-or-later > BuildRequires: make ^ add BR on make > make %{?_smp_mflags} You can use %make_build without %{?_smp_mflags} > make install Same, use %make_install macro > %{_bindir}/* Don't use wildcard, specify what binaries will be packaged. > %{_mandir}/man1/* Change to %{_mandir}/man1/FILE.X*, for example: %{_mandir}/man1/gnudos.1* > %{_libdir}/libgnudos.so.2 > %{_libdir}/libgnudos.so.2.0.0 Create a libs package with these. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2301667 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202301667%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
