https://bugzilla.redhat.com/show_bug.cgi?id=2299972 --- Comment #5 from Kyle Gospodnetich <me@xxxxxxxxxxxxxxxxx> --- The remaining requested changes have been made as well as some others. * Line breaks added to shorten the description * Git removed as a BuildDependency * localconf now used per project's makefile * BEES_VERSION corrected with prefixed v * Tests added in %check * Missing wildcard in post systemd step fixed * Folder name specified in %files without wildcard The tests are both built and ran in check, but I can adjust that so that they're built in the build step and only ran in the check step if that's incorrect. I also didn't see a macro for make test so please let me know if I'm missing something. * Spec URL: https://pagure.io/bees/raw/f40/f/bees.spec * SRPM URL: https://pagure.io/bees/blob/f40/f/rpmbuild/SRPM/bees-0.10-1.fc40.src.rpm * F40 Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=121334742 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2299972 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299972%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
