https://bugzilla.redhat.com/show_bug.cgi?id=2300832 --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #1) > Hi Ben, > > Going through this now. Quick question: the pypi source does seem to include > tests and upstream does run them in their CI: > > https://github.com/wtclarke/spec2nii/blob/master/.github/workflows/push_pr. > yml > > but they're not run during the build (a missing `%bcond tests 1` perhaps?): > should we try enabling them to see if they run? Absolutely! I am shocked I missed that the tests were not enabled. I’ll get them working and upload a new submission. > Another minor note: is it worth trying to generate the man pages as part of > the build (as we do using help2man) if possible so that one doesn't have to > manually check/update them for each release? I could do that, but the hand-written ones are a bit nicer, I can easily have cross-references, and it’s a bit fussy to run help2man for each subcommand. Given that I don’t expect a lot of change upstream, I’m going to stick with the hand-written ones for now. If upstream were fast-moving, I would work harder at automating this. I do have that problem with uv, and I’m looking into a way to script discovery and generation of a collection of man pages for a tree of subcommands, but it’s a bit of a fussy thing to do nicely. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2300832 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202300832%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
