https://bugzilla.redhat.com/show_bug.cgi?id=2299129 --- Comment #2 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #1) > Package Review > ============== > > Looking good. I noticed it bundles fonts, octicons (MIT licensed). I guess we > should at least note the bundling in the spec? Good catch. I think a 'Provides bundled(...)' would be warranted. Though, I'm not exactly sure what to put in place of '...'. Having bumped into a few questionable items license wise, I'm also wondering about [1]: ``` (c) GitHub, Inc. When using the GitHub logos, be sure to follow the GitHub logo guidelines. Code License: MIT Applies to all other files ``` I will check that no GitHub logos are being used, in which case I assume you are right that MIT should apply. [1] https://github.com/primer/octicons/tree/main#license -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2299129 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299129%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
