https://bugzilla.redhat.com/show_bug.cgi?id=2283541 --- Comment #7 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thanks for the review! (In reply to Ben Beasley from comment #6) > - There is a small typo (actuall/actually) here: > > # Make sure we actuall ship the file containing the license > > but it is not very important. Still, you may wish to fix it on import. I'll fix on import. Looks like rpmlint's spell check could be useful, if only... > The assignment of LicenseRef-Fedora-Public-Domain is supported by > Fedora Legal > opinion, and the text was added to public-domain-text.txt. > > It could be helpful to add a link to > > https://lists.fedoraproject.org/archives/list/legal@xxxxxxxxxxxxxxxxxxxxxxx/ > message/44KT5NKIT77ZWME464KDBYNH6WBCG4DA/ > to the spec file to assist anyone who comes along later and tries to > understand the rationale for the License field. That's a good idea. I will put it in there. Though, this review has all the required information as well. And that would be _my_ first stop when questioning. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283541 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283541%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
