https://bugzilla.redhat.com/show_bug.cgi?id=2295820 --- Comment #19 from Tim Flink <tflink@xxxxxxxxxx> --- Created attachment 2041182 --> https://bugzilla.redhat.com/attachment.cgi?id=2041182&action=edit specfile changes for discussion I've attached an initial patch for the hipblaslt specfile that contains a few things, three are pretty minor: 1. I changed a few of the BuildRequires to use pkgconfig where appropriate 2. I added a different way to disable the rpath check disable when building --with test that works with mock. I'd like to have this in all of the rocm packages that have -test subpackages to make building them easier but this can wait for a more general discussion, it doesn't have to be added now if there are objections. 3. I added some missing deps from the -test subpackage The last one is more of a discussion: One of the BuildRequires for the -test subpackage (libomp) needs to match the llvm version AFAIK. I understand why that information was removed from the specfile and I agree with it but I'm left with a problem - the BuildRequires are evaluated before rocm-compilersupport-macros is installed and I can't use %{rocmllvm_version} macro to specify the llvm version for a BuildRequires package. Any thoughts on how to address this? I can't think of much more than local macro for something like %{rocm_llvmversion_test} that wouldn't impact the non-test builds but whoever is doing the test builds would need to be aware of the potential/eventual sync break WRT the locally specified version. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2295820 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295820%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
